chrome/browser/ui/startup/startup_browser_creator_impl.cc - Issue 111553008: Add PerAppSettingsService and use it to remember what desktop apps should create windows on.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/startup/startup_browser_creator_impl.cc

Issue 111553008: Add PerAppSettingsService and use it to remember what desktop apps should create windows on. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: redirect PerAppSettingsService in incognito mode because component apps can run in incognito mode (… Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/extensions/application_launch.cc ('k') | chrome/browser/ui/views/apps/native_app_window_views_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/startup/startup_browser_creator_impl.cc

diff --git a/chrome/browser/ui/startup/startup_browser_creator_impl.cc b/chrome/browser/ui/startup/startup_browser_creator_impl.cc

index a62a1bdc726e2e2d382dade80c6ff9d83c6f84f7..6c178f74317595395fcd4dfc0d7df2b76bfea14a 100644

--- a/chrome/browser/ui/startup/startup_browser_creator_impl.cc

+++ b/chrome/browser/ui/startup/startup_browser_creator_impl.cc

@@ -376,6 +376,9 @@ bool StartupBrowserCreatorImpl::Launch(Profile* profile,

extensions::LAUNCH_CONTAINER_NONE, NEW_WINDOW);

params.command_line = command_line_;

params.current_directory = cur_dir_;

+ // If we are being launched from the command line, default to native

+ // desktop.

+ params.desktop_type = chrome::HOST_DESKTOP_TYPE_NATIVE;

OpenApplicationWithReenablePrompt(params);

return true;

}

« no previous file with comments | « chrome/browser/ui/extensions/application_launch.cc ('k') | chrome/browser/ui/views/apps/native_app_window_views_win.cc » ('j') | no next file with comments »