Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 1115513002: Expose additional flags for rasterization. (Closed)

Created:
5 years, 7 months ago by Scott Byer
Modified:
5 years, 7 months ago
CC:
paolof_chromium.org, pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Expose additional flags for rasterization. These flags are unused in Chromium, but are needed for the Cloud Print conversion process, which takes PDF and produces a raster for low-end printers. Certain low-end printers (e.g., B&W laser printers) will turn anti-aliased text into a mess. The existing printing flag isn't sufficient, as other kinds of printers will still want some kinds of anti-aliasing to occur for best results. BUG=482253 TEST=none Committed: https://pdfium.googlesource.com/pdfium/+/5dee6299cc103e5e0bfb138198f2369856ee81a9

Patch Set 1 #

Patch Set 2 : git cl upload --no-find-copies #

Patch Set 3 : rebase #

Total comments: 2

Patch Set 4 : Tweak flag define names. #

Patch Set 5 : Trying to get issue clean for landing. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M fpdfsdk/include/fpdfview.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M fpdfsdk/src/fpdfview.cpp View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
5 years, 7 months ago (2015-04-29 00:47:51 UTC) #4
Scott Byer
Hey, Vitaly, do you feel comfortable looking at this? It's a pretty simple change.
5 years, 7 months ago (2015-05-04 20:06:46 UTC) #6
Scott Byer
rebase
5 years, 7 months ago (2015-05-04 20:08:05 UTC) #7
Vitaly Buka (NO REVIEWS)
lgtm https://codereview.chromium.org/1115513002/diff/40001/fpdfsdk/include/fpdfview.h File fpdfsdk/include/fpdfview.h (right): https://codereview.chromium.org/1115513002/diff/40001/fpdfsdk/include/fpdfview.h#newcode331 fpdfsdk/include/fpdfview.h:331: #define FPDF_NO_NATIVETEXT 0x04 // Don't use the native ...
5 years, 7 months ago (2015-05-04 22:18:28 UTC) #8
Scott Byer
https://codereview.chromium.org/1115513002/diff/40001/fpdfsdk/include/fpdfview.h File fpdfsdk/include/fpdfview.h (right): https://codereview.chromium.org/1115513002/diff/40001/fpdfsdk/include/fpdfview.h#newcode331 fpdfsdk/include/fpdfview.h:331: #define FPDF_NO_NATIVETEXT 0x04 // Don't use the native text ...
5 years, 7 months ago (2015-05-04 23:23:46 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-04 23:28:18 UTC) #15
Commit queue rejected this change because it did not recognize the base URL.
Please commit your change manually.

Powered by Google App Engine
This is Rietveld 408576698