If-then-else support for GRIT

grit/node/misc.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Miscellaneous node types.
 """
 
 import os.path
 import re
@@ skipping 68 matching lines @@
     return self.parent._IsValidChild(child)
 
 
 class IfNode(SplicingNode):
   """A node for conditional inclusion of resources.
   """
 
   def MandatoryAttributes(self):
     return ['expr']
 
+  def _IsValidChild(self, child):
+    return (isinstance(child, (ThenNode, ElseNode)) or
+            super(IfNode, self)._IsValidChild(child))
+
+  def EndParsing(self):
+    children = self.children
+    if any(isinstance(node, (ThenNode, ElseNode)) for node in children):
+      if (len(children) != 2 or not isinstance(children[0], ThenNode) or
+                                not isinstance(children[1], ElseNode)):
+        raise exception.UnexpectedChild(
+            '<if> element must be <if><then>...</then><else>...</else></if>')
+
   def ActiveChildren(self):
-    if not self.EvaluateCondition(self.attrs['expr']):
-      return []
-    return super(IfNode, self).ActiveChildren()
+    cond = self.EvaluateCondition(self.attrs['expr'])
+    if len(self.children) == 2 and isinstance(self.children[0], ThenNode):

[Jói, 2012/10/16 11:21:11]

This is slightly hard to follow; I think a comment explaining that it's to
support <then> and <else> when present, or an implicit <then> when not present,
would help readability.

+      return self.children[0 if cond else 1].ActiveChildren()
+    else:
+      return super(IfNode, self).ActiveChildren() if cond else []
+
+
+class ThenNode(SplicingNode):
+  """A <then> node. Can only appear directly inside an <if> node."""
+  pass
+
+
+class ElseNode(SplicingNode):
+  """An <else> node. Can only appear directly inside an <if> node."""
+  pass
 
 
 class PartNode(SplicingNode):
   """A node for inclusion of sub-grd (*.grp) files.
   """
 
   def __init__(self):
     super(PartNode, self).__init__()
     self.started_inclusion = False
 
@@ skipping 372 matching lines @@
     by parameters of the same name.
     """
     node = IdentifierNode()
     node.StartParsing('identifier', parent)
     node.HandleAttribute('name', name)
     node.HandleAttribute('id', id)
     node.HandleAttribute('comment', comment)
     node.HandleAttribute('systemid', systemid)
     node.EndParsing()
     return node