Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1270)

Unified Diff: ui/views/controls/progress_bar.cc

Issue 11155002: views: Fix progress bar tooltip text function. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix review comments Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/views/controls/progress_bar_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/progress_bar.cc
diff --git a/ui/views/controls/progress_bar.cc b/ui/views/controls/progress_bar.cc
index 0b93a1fc3f9552a1393efd040bef4353305f1eac..e07e0ecc49ae9be8d87a2214f0a89dc7195b97a4 100644
--- a/ui/views/controls/progress_bar.cc
+++ b/ui/views/controls/progress_bar.cc
@@ -41,8 +41,6 @@ void AddRoundRectPathWithPadding(int x, int y,
SkScalar padding,
SkPath* path) {
DCHECK(path);
- if (path == NULL)
- return;
SkRect rect;
rect.set(
SkIntToScalar(x) + padding, SkIntToScalar(y) + padding,
@@ -169,9 +167,7 @@ void ProgressBar::SetTooltipText(const string16& tooltip_text) {
bool ProgressBar::GetTooltipText(const gfx::Point& p, string16* tooltip) const {
DCHECK(tooltip);
- if (tooltip == NULL)
- return false;
- tooltip->assign(tooltip_text_);
+ *tooltip = tooltip_text_;
return !tooltip_text_.empty();
}
« no previous file with comments | « no previous file | ui/views/controls/progress_bar_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698