Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1115453003: Introduce a Blink API for checking whether a certain locale could be valid. (Closed)

Created:
5 years, 7 months ago by Peter Beverloo
Modified:
5 years, 5 months ago
Reviewers:
philipj_slow
CC:
blink-reviews, dglazkov+blink
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Introduce a Blink API for checking whether a certain locale could be valid. Both the Web Notification API and the Media Source Extensions API define algorithms which validate BCP 47 language tags. Chromium has a function to check if a string is plausibly could be a syntactically- valid locale string that we can use for this purpose. We do not check whether the BCP 47 tag *actually* is valid, but rather if the syntax of the tag could be valid. Additional checks can be added later, but this at least makes sure that there won't be completely random data in the fields. This CL is part of a three-sided patch: [1] This CL. [2] https://codereview.chromium.org/1110233002/ [3] https://codereview.chromium.org/1110223002/ BUG=442137

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M public/platform/Platform.h View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Peter Beverloo
5 years, 7 months ago (2015-04-28 19:17:25 UTC) #2
+philipj since this touches MSE and the public/ API

Powered by Google App Engine
This is Rietveld 408576698