src/core/SkTDynamicHash.h - Issue 1115433004: Fix SkTDynamicHash.h:183:29: warning: equality comparison with extraneous parentheses [-Wparenthese…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkTDynamicHash.h

Issue 1115433004: Fix SkTDynamicHash.h:183:29: warning: equality comparison with extraneous parentheses [-Wparenthese… (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/core/SkTDynamicHash.h

diff --git a/src/core/SkTDynamicHash.h b/src/core/SkTDynamicHash.h

index 23544c8b86fdd2c36687bcf9b8c931dbb7394947..8def89b9ca8107f04aef4ac093357df692d8adce 100644

--- a/src/core/SkTDynamicHash.h

+++ b/src/core/SkTDynamicHash.h

@@ -161,7 +161,7 @@ private:

static T* Deleted() { return reinterpret_cast<T*>(1); } // Also an invalid pointer.

bool validate() const {

- #define SKTDYNAMICHASH_CHECK(x) SkASSERT((x)); if (!(x)) return false

+ #define SKTDYNAMICHASH_CHECK(x) SkASSERT(x); if (!(x)) return false

static const int kLarge = 50; // Arbitrary, tweak to suit your patience.

// O(1) checks, always done.

« no previous file with comments | « no previous file | no next file » | no next file with comments »