Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 111543005: DevTools: Restore capture async traces state on page navigation. (Closed)

Created:
7 years ago by aandrey
Modified:
7 years ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: Restore capture async traces state on page navigation. BUG=272416 R=pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163693

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M Source/core/inspector/InspectorDebuggerAgent.cpp View 1 2 4 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
aandrey
7 years ago (2013-12-10 16:50:13 UTC) #1
pfeldman
https://codereview.chromium.org/111543005/diff/1/Source/core/inspector/InspectorDebuggerAgent.cpp File Source/core/inspector/InspectorDebuggerAgent.cpp (right): https://codereview.chromium.org/111543005/diff/1/Source/core/inspector/InspectorDebuggerAgent.cpp#newcode936 Source/core/inspector/InspectorDebuggerAgent.cpp:936: m_state->setLong(DebuggerAgentState::asyncCallStackDepth, depth); You want to clear it in disable. ...
7 years ago (2013-12-10 17:20:53 UTC) #2
aandrey
https://codereview.chromium.org/111543005/diff/1/Source/core/inspector/InspectorDebuggerAgent.cpp File Source/core/inspector/InspectorDebuggerAgent.cpp (right): https://codereview.chromium.org/111543005/diff/1/Source/core/inspector/InspectorDebuggerAgent.cpp#newcode936 Source/core/inspector/InspectorDebuggerAgent.cpp:936: m_state->setLong(DebuggerAgentState::asyncCallStackDepth, depth); On 2013/12/10 17:20:54, pfeldman wrote: > You ...
7 years ago (2013-12-11 08:14:18 UTC) #3
pfeldman
lgtm
7 years ago (2013-12-11 08:28:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/111543005/40001
7 years ago (2013-12-11 08:47:13 UTC) #5
commit-bot: I haz the power
7 years ago (2013-12-11 09:56:37 UTC) #6
Message was sent while issue was closed. 
Change committed as 163693

Powered by Google App Engine
This is Rietveld 408576698