Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9179)

Unified Diff: chrome/renderer/chrome_content_renderer_client.cc

Issue 11154027: Merge 162026 - White-list the two ssh client webstore ids besides quickoffice. (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1271/src/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/chrome_content_renderer_client.cc
===================================================================
--- chrome/renderer/chrome_content_renderer_client.cc (revision 162033)
+++ chrome/renderer/chrome_content_renderer_client.cc (working copy)
@@ -586,6 +586,19 @@
return GURL();
}
+// TODO(dschuff): remove this when ARM ABI is stable
+#if defined(__arm__) && defined(OS_CHROMEOS)
+static bool IsWhiteListedARM(const GURL& url) {
+ return
+ // QuickOffice
+ url.host() == "gbkeegbaiigmenfmjfclcdgdpimamgkj" ||
+ // ssh dev
+ url.host() == "okddffdblfhhnmhodogpojmfkjmhinfp" ||
+ // ssh stable
+ url.host() == "pnhechapfaindjhompbnflcldabbghjo";
+}
+#endif
+
// static
bool ChromeContentRendererClient::IsNaClAllowed(
const GURL& manifest_url,
@@ -606,15 +619,15 @@
// under development, invocations from whitelisted URLs, and all invocations
// if --enable-nacl is set.
bool is_nacl_allowed =
-#if defined(__arm__)
+#if defined(__arm__) && defined(OS_CHROMEOS)
// The ARM ABI is not quite stable, so only allow NaCl for
// unrestricted extensions (i.e. built-in and under development),
- // and for the QuickOffice webstore app.
+ // and for certain whitelisted webstore apps.
// See http://crbug.com/145694
// TODO(dschuff): remove this when the ABI is stable
(is_extension_from_webstore &&
manifest_url.SchemeIs("chrome-extension") &&
- manifest_url.host() == "gbkeegbaiigmenfmjfclcdgdpimamgkj") ||
+ IsWhiteListedARM(manifest_url) ||
#else
is_extension_from_webstore ||
is_whitelisted_url ||
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698