Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Issue 11154011: Improve exception handling. (Closed)

Created:
8 years, 2 months ago by M-A Ruel
Modified:
8 years, 2 months ago
Reviewers:
csharp
CC:
chromium-reviews
Base URL:
https://git.chromium.org/chromium/tools/swarm_client.git@master
Visibility:
Public.

Description

Improve exception handling. Saves the stack trace and raise it back in the 3-tuples form so it is easier to diagnose the root cause. R=csharp@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161858

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M run_test_cases.py View 1 chunk +1 line, -1 line 0 comments Download
M trace_inputs.py View 3 chunks +9 lines, -4 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
M-A Ruel
8 years, 2 months ago (2012-10-15 15:30:01 UTC) #1
csharp
lgtm https://codereview.chromium.org/11154011/diff/1/trace_inputs.py File trace_inputs.py (right): https://codereview.chromium.org/11154011/diff/1/trace_inputs.py#newcode3045 trace_inputs.py:3045: raise \ Would it be better to use ...
8 years, 2 months ago (2012-10-15 15:38:27 UTC) #2
M-A Ruel
https://codereview.chromium.org/11154011/diff/1/trace_inputs.py File trace_inputs.py (right): https://codereview.chromium.org/11154011/diff/1/trace_inputs.py#newcode3045 trace_inputs.py:3045: raise \ On 2012/10/15 15:38:28, csharp wrote: > Would ...
8 years, 2 months ago (2012-10-15 15:40:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/11154011/1
8 years, 2 months ago (2012-10-15 15:42:10 UTC) #4
commit-bot: I haz the power
8 years, 2 months ago (2012-10-15 15:42:40 UTC) #5
Change committed as 161858

Powered by Google App Engine
This is Rietveld 408576698