Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Side by Side Diff: tools/perf/measurements/smoothness_unittest.py

Issue 1115383002: Disable failing telemetry unit tests on chromeos. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: perf2 Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 import sys 4 import sys
5 5
6 from telemetry.core import wpr_modes 6 from telemetry.core import wpr_modes
7 from telemetry import decorators 7 from telemetry import decorators
8 from telemetry.page import page 8 from telemetry.page import page
9 from telemetry.unittest_util import options_for_unittests 9 from telemetry.unittest_util import options_for_unittests
10 from telemetry.unittest_util import page_test_test_case 10 from telemetry.unittest_util import page_test_test_case
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 sys.stderr.write("Expected category filter: %s\n" % 75 sys.stderr.write("Expected category filter: %s\n" %
76 repr(expected_category_filter)) 76 repr(expected_category_filter))
77 sys.stderr.write("Actual category filter filter: %s\n" % 77 sys.stderr.write("Actual category filter filter: %s\n" %
78 repr(actual_category_filter)) 78 repr(actual_category_filter))
79 self.assertEquals(expected_category_filter, actual_category_filter) 79 self.assertEquals(expected_category_filter, actual_category_filter)
80 80
81 def setUp(self): 81 def setUp(self):
82 self._options = options_for_unittests.GetCopy() 82 self._options = options_for_unittests.GetCopy()
83 self._options.browser_options.wpr_mode = wpr_modes.WPR_OFF 83 self._options.browser_options.wpr_mode = wpr_modes.WPR_OFF
84 84
85 @decorators.Disabled('chromeos') # crbug.com/483212
85 def testSmoothness(self): 86 def testSmoothness(self):
86 ps = self.CreatePageSetFromFileInUnittestDataDir('scrollable_page.html') 87 ps = self.CreatePageSetFromFileInUnittestDataDir('scrollable_page.html')
87 measurement = smoothness.Smoothness() 88 measurement = smoothness.Smoothness()
88 results = self.RunMeasurement(measurement, ps, options=self._options) 89 results = self.RunMeasurement(measurement, ps, options=self._options)
89 self.assertEquals(0, len(results.failures)) 90 self.assertEquals(0, len(results.failures))
90 91
91 frame_times = results.FindAllPageSpecificValuesNamed('frame_times') 92 frame_times = results.FindAllPageSpecificValuesNamed('frame_times')
92 self.assertEquals(len(frame_times), 1) 93 self.assertEquals(len(frame_times), 1)
93 self.assertGreater(frame_times[0].GetRepresentativeNumber(), 0) 94 self.assertGreater(frame_times[0].GetRepresentativeNumber(), 0)
94 95
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 max_frame_delay = results.FindAllPageSpecificValuesNamed('max_frame_delay') 132 max_frame_delay = results.FindAllPageSpecificValuesNamed('max_frame_delay')
132 self.assertEquals(1, len(max_frame_delay)) 133 self.assertEquals(1, len(max_frame_delay))
133 self.assertGreater(max_frame_delay[0].GetRepresentativeNumber, 0) 134 self.assertGreater(max_frame_delay[0].GetRepresentativeNumber, 0)
134 135
135 frame_lengths = results.FindAllPageSpecificValuesNamed('frame_lengths') 136 frame_lengths = results.FindAllPageSpecificValuesNamed('frame_lengths')
136 self.assertEquals(1, len(frame_lengths)) 137 self.assertEquals(1, len(frame_lengths))
137 self.assertGreater(frame_lengths[0].GetRepresentativeNumber, 0) 138 self.assertGreater(frame_lengths[0].GetRepresentativeNumber, 0)
138 139
139 def testCleanUpTrace(self): 140 def testCleanUpTrace(self):
140 self.TestTracingCleanedUp(smoothness.Smoothness, self._options) 141 self.TestTracingCleanedUp(smoothness.Smoothness, self._options)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698