Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Side by Side Diff: Source/core/html/HTMLFormControlElement.cpp

Issue 1115353002: Update renderer to layoutObject in core/html. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/html/HTMLEmbedElement.cpp ('k') | Source/core/html/HTMLFormElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 219 matching lines...) Expand 10 before | Expand all | Expand 10 after
230 230
231 void HTMLFormControlElement::attach(const AttachContext& context) 231 void HTMLFormControlElement::attach(const AttachContext& context)
232 { 232 {
233 HTMLElement::attach(context); 233 HTMLElement::attach(context);
234 234
235 if (!layoutObject()) 235 if (!layoutObject())
236 return; 236 return;
237 237
238 // The call to updateFromElement() needs to go after the call through 238 // The call to updateFromElement() needs to go after the call through
239 // to the base class's attach() because that can sometimes do a close 239 // to the base class's attach() because that can sometimes do a close
240 // on the renderer. 240 // on the layoutObject.
241 layoutObject()->updateFromElement(); 241 layoutObject()->updateFromElement();
242 242
243 // FIXME: Autofocus handling should be moved to insertedInto according to 243 // FIXME: Autofocus handling should be moved to insertedInto according to
244 // the standard. 244 // the standard.
245 if (shouldAutofocusOnAttach(this)) 245 if (shouldAutofocusOnAttach(this))
246 document().setAutofocusElement(this); 246 document().setAutofocusElement(this);
247 } 247 }
248 248
249 void HTMLFormControlElement::didMoveToNewDocument(Document& oldDocument) 249 void HTMLFormControlElement::didMoveToNewDocument(Document& oldDocument)
250 { 250 {
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
353 return m_isRequired; 353 return m_isRequired;
354 } 354 }
355 355
356 String HTMLFormControlElement::resultForDialogSubmit() 356 String HTMLFormControlElement::resultForDialogSubmit()
357 { 357 {
358 return fastGetAttribute(valueAttr); 358 return fastGetAttribute(valueAttr);
359 } 359 }
360 360
361 void HTMLFormControlElement::didRecalcStyle(StyleRecalcChange) 361 void HTMLFormControlElement::didRecalcStyle(StyleRecalcChange)
362 { 362 {
363 if (LayoutObject* renderer = this->layoutObject()) 363 if (LayoutObject* layoutObject = this->layoutObject())
364 renderer->updateFromElement(); 364 layoutObject->updateFromElement();
365 } 365 }
366 366
367 bool HTMLFormControlElement::supportsFocus() const 367 bool HTMLFormControlElement::supportsFocus() const
368 { 368 {
369 return !isDisabledFormControl(); 369 return !isDisabledFormControl();
370 } 370 }
371 371
372 bool HTMLFormControlElement::isKeyboardFocusable() const 372 bool HTMLFormControlElement::isKeyboardFocusable() const
373 { 373 {
374 // Skip tabIndex check in a parent class. 374 // Skip tabIndex check in a parent class.
(...skipping 266 matching lines...) Expand 10 before | Expand all | Expand 10 after
641 dispatchFormControlChangeEvent(); 641 dispatchFormControlChangeEvent();
642 } 642 }
643 643
644 void HTMLFormControlElement::copyNonAttributePropertiesFromElement(const Element & source) 644 void HTMLFormControlElement::copyNonAttributePropertiesFromElement(const Element & source)
645 { 645 {
646 HTMLElement::copyNonAttributePropertiesFromElement(source); 646 HTMLElement::copyNonAttributePropertiesFromElement(source);
647 setNeedsValidityCheck(); 647 setNeedsValidityCheck();
648 } 648 }
649 649
650 } // namespace blink 650 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/html/HTMLEmbedElement.cpp ('k') | Source/core/html/HTMLFormElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698