chrome/app/chrome_main_delegate.cc - Issue 1115343002: Added a whitelist for trace events that are known to be PII-less.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/chrome_main_delegate.cc

Issue 1115343002: Added a whitelist for trace events that are known to be PII-less. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review fixes Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/app/chrome_main_delegate.cc

diff --git a/chrome/app/chrome_main_delegate.cc b/chrome/app/chrome_main_delegate.cc

index 5f4d00f1f438d2202cc15ad6d848d519976a59a4..747d482086c36e087ddc5f7ed2031d51054133d4 100644

--- a/chrome/app/chrome_main_delegate.cc

+++ b/chrome/app/chrome_main_delegate.cc

@@ -16,6 +16,7 @@

#include "base/process/memory.h"

#include "base/process/process_handle.h"

#include "base/strings/string_util.h"

+#include "base/trace_event/trace_event_impl.h"

#include "build/build_config.h"

#include "chrome/browser/chrome_content_browser_client.h"

#include "chrome/browser/defaults.h"

@@ -30,6 +31,7 @@

#include "chrome/common/logging_chrome.h"

#include "chrome/common/profiling.h"

#include "chrome/common/switch_utils.h"

+#include "chrome/common/trace_event_args_whitelist.h"

#include "chrome/common/url_constants.h"

#include "chrome/plugin/chrome_content_plugin_client.h"

#include "chrome/renderer/chrome_content_renderer_client.h"

@@ -438,6 +440,9 @@ bool ChromeMainDelegate::BasicStartupComplete(int* exit_code) {

Profiling::ProcessStarted();

+ base::trace_event::TraceLog::GetInstance()->SetArgumentFilterPredicate(

+ base::Bind(&IsTraceEventArgsWhitelisted));

#if defined(OS_WIN)

v8_breakpad_support::SetUp();

#endif

« no previous file with comments | « base/trace_event/trace_event_unittest.cc ('k') | chrome/chrome_common.gypi » ('j') | chrome/common/trace_event_args_whitelist.cc » ('J')