Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(999)

Unified Diff: content/browser/tracing/tracing_controller_impl.cc

Issue 1115343002: Added a whitelist for trace events that are known to be PII-less. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Moved whitelist to chrome Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/tracing/child_trace_message_filter.cc ('k') | content/content_common.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/tracing/tracing_controller_impl.cc
diff --git a/content/browser/tracing/tracing_controller_impl.cc b/content/browser/tracing/tracing_controller_impl.cc
index 3a235fe5bdaf803c7790dfdb12de1e554e952550..4a1a5adab293fda919133e66102b6eb17a29d9b6 100644
--- a/content/browser/tracing/tracing_controller_impl.cc
+++ b/content/browser/tracing/tracing_controller_impl.cc
@@ -13,6 +13,7 @@
#include "content/browser/tracing/tracing_ui.h"
#include "content/common/child_process_messages.h"
#include "content/public/browser/browser_message_filter.h"
+#include "content/public/common/content_client.h"
#include "content/public/common/content_switches.h"
#if defined(OS_CHROMEOS)
@@ -96,6 +97,11 @@ void TracingControllerImpl::SetEnabledOnFileThread(
TraceLog::GetInstance()->SetEnabled(
category_filter, static_cast<TraceLog::Mode>(mode), trace_options);
+ if (trace_options.enable_args_whitelist) {
+ TraceLog::GetInstance()->SetEventFilterPredicate(
+ GetContentClient()->GetTraceEventFilterPredicate());
jam 2015/05/12 23:16:32 why do you need to change content? seems like chr
oystein (OOO til 10th of July) 2015/05/12 23:25:12 Tracing is primarily a content/ concept; there's n
+ }
+
BrowserThread::PostTask(BrowserThread::UI, FROM_HERE, callback);
}
« no previous file with comments | « components/tracing/child_trace_message_filter.cc ('k') | content/content_common.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698