chrome/common/trace_event_args_whitelist.h - Issue 1115343002: Added a whitelist for trace events that are known to be PII-less.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/trace_event_args_whitelist.h

Issue 1115343002: Added a whitelist for trace events that are known to be PII-less. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Always set the predicate Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_COMMON_TRACE_EVENT_ARGS_WHITELIST_H_

	6 #define CHROME_COMMON_TRACE_EVENT_ARGS_WHITELIST_H_

	7

	8 namespace chrome {
	jam 2015/05/20 15:30:18 nit: using "chrome" namespace is deprecated. as ch nit: using "chrome" namespace is deprecated. as chrome is a leaf node, its code doesn't need to be in a namespace (see cr-dev threads on this) oystein (OOO til 10th of July) 2015/05/20 21:25:01 Done. Show quoted text On 2015/05/20 15:30:18, jam wrote: > nit: using "chrome" namespace is deprecated. as chrome is a leaf node, its code > doesn't need to be in a namespace (see cr-dev threads on this) Done.
	9

	10 bool IsTraceEventArgsWhitelisted(const char* category_group_name,
	jam 2015/05/20 15:30:18 nit: add brief comment about what this method is u nit: add brief comment about what this method is used for oystein (OOO til 10th of July) 2015/05/20 21:25:01 Done. Show quoted text On 2015/05/20 15:30:18, jam wrote: > nit: add brief comment about what this method is used for Done.
	11 const char* event_name);

	12

	13 } // namespace chrome

	14

	15 #endif // CHROME_COMMON_TRACE_EVENT_ARGS_WHITELIST_H_

OLD	NEW

« no previous file with comments | « chrome/common/OWNERS ('k') | chrome/common/trace_event_args_whitelist.cc » ('j') | no next file with comments »