Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: Source/bindings/v8/ExceptionMessages.cpp

Issue 111533002: Have document.evaluate() report TypeError over incorrect resolvers. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/ExceptionMessages.cpp
diff --git a/Source/bindings/v8/ExceptionMessages.cpp b/Source/bindings/v8/ExceptionMessages.cpp
index 613fa571b68ca394f17877c4bbc436168e2bbd4a..f8e071bb7933377b994ba7ce9bea08344eab4508 100644
--- a/Source/bindings/v8/ExceptionMessages.cpp
+++ b/Source/bindings/v8/ExceptionMessages.cpp
@@ -62,7 +62,12 @@ String ExceptionMessages::failedToDelete(const String& property, const String& t
String ExceptionMessages::incorrectPropertyType(const String& property, const String& detail)
{
- return "The '" + property + "' property " + detail;
+ return "The '" + property + "' property " + (!detail.isEmpty() ? detail : "does not have the expected type.");
+}
+
+String ExceptionMessages::incorrectArgumentType(int argumentIndex, const String& detail)
+{
+ return "The " + ordinalNumber(argumentIndex) + " argument " + (!detail.isEmpty() ? detail : "does not have the expected type.");
}
String ExceptionMessages::notAnArrayTypeArgumentOrValue(int argumentIndex)

Powered by Google App Engine
This is Rietveld 408576698