Blacklist tiles_rt-gpu gm imagefilterscropped on GalaxyS4

Blacklist tiles_rt-gpu gm imagefilterscropped on GalaxyS4

BUG=skia:3802
Committed: https://skia.googlesource.com/skia/+/f4e0857fe9e7b606c36302a252f23a790427f899

[borenet, 2015-05-05 14:20:54]

borenet@google.com changed reviewers:
+ mtklein@google.com

[borenet, 2015-05-05 14:20:55]

Is this the right format?  I don't know why the trybot gets a segfault.

[mtklein, 2015-05-05 14:28:53]

https://codereview.chromium.org/1115303004/diff/1/tools/dm_flags.py
File tools/dm_flags.py (right):

https://codereview.chromium.org/1115303004/diff/1/tools/dm_flags.py#newcode131
tools/dm_flags.py:131: blacklist.extend('gpu gm tiles_rt
imagefilterscropped'.split(' '))
I think "tiles_rt-gpu gm _ imagefilterscropped" ought to do it.  Or
"tiles_rt-gpu _ _ imagefilterscropped".

It's sink / src / src-options / name.

[borenet, 2015-05-05 14:55:28]

https://codereview.chromium.org/1115303004/diff/1/tools/dm_flags.py
File tools/dm_flags.py (right):

https://codereview.chromium.org/1115303004/diff/1/tools/dm_flags.py#newcode131
tools/dm_flags.py:131: blacklist.extend('gpu gm tiles_rt
imagefilterscropped'.split(' '))
On 2015/05/05 14:28:53, mtklein wrote:
> I think "tiles_rt-gpu gm _ imagefilterscropped" ought to do it.  Or
> "tiles_rt-gpu _ _ imagefilterscropped".
> 
> It's sink / src / src-options / name.

Cool, thanks.

[mtklein, 2015-05-05 14:58:32]

lgtm

[borenet, 2015-05-05 15:16:37]

The CQ bit was checked by borenet@google.com

[commit-bot: I haz the power, 2015-05-05 15:16:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1115303004/40001

[commit-bot: I haz the power, 2015-05-05 15:16:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-05 15:16:54]

Failed to apply patch for tools/dm_flags.py:
While running git apply --index -3 -p1;
  error: patch failed: tools/dm_flags.py:127
  Falling back to three-way merge...
  Applied patch to 'tools/dm_flags.py' with conflicts.
  U tools/dm_flags.py

Patch:       tools/dm_flags.py
Index: tools/dm_flags.py
diff --git a/tools/dm_flags.py b/tools/dm_flags.py
index
7715a07f588d1d25f79862561327d66dbc62039d..451f37c7ac1778635196ea7384c23d5ffeb6c86d
100755
--- a/tools/dm_flags.py
+++ b/tools/dm_flags.py
@@ -127,6 +127,10 @@ def get_args(bot):
     blacklist.extend('pdf skp _ desk_baidu.skp'.split(' '))
     blacklist.extend('pdf skp _ desk_wikipedia.skp'.split(' '))
 
+  if 'GalaxyS4' in bot:
+    # This occasionally runs forever. skia:3802
+    blacklist.extend('tiles_rt-gpu gm _ imagefilterscropped'.split(' '))
+
   if blacklist:
     args.append('--blacklist')
     args.extend(blacklist)

[borenet, 2015-05-05 15:18:59]

The CQ bit was checked by borenet@google.com

[borenet, 2015-05-05 15:18:59]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com
Link to the patchset: https://codereview.chromium.org/1115303004/#ps60001
(title: "rebas")

[commit-bot: I haz the power, 2015-05-05 15:19:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1115303004/60001

[commit-bot: I haz the power, 2015-05-05 15:28:27]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/f4e0857fe9e7b606c36302a252f23a790427f899