win: Fix remaining plugin warnings in ash, device, printing, sandbox.

win: Fix remaining plugin warnings in ash, device, printing, sandbox.

https://www.chromium.org/developers/coding-style/chromium-style-checker-errors

BUG=467287
TBR=cpu

Committed: https://crrev.com/94b360568b3ea199c64312060a82477661624ea9
Cr-Commit-Position: refs/heads/master@{#327773}

[Nico, 2015-04-30 18:33:01]

thakis@chromium.org changed reviewers:
+ dcheng@chromium.org

[dcheng, 2015-04-30 18:36:55]

lgtm

[Nico, 2015-04-30 19:06:33]

The CQ bit was checked by thakis@chromium.org

[Nico, 2015-04-30 19:06:33]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/1115293002/#ps20001
(title: ".")

[Nico, 2015-04-30 19:06:54]

thakis@chromium.org changed reviewers:
+ cpu@chromium.org

[Nico, 2015-04-30 19:06:55]

tbr'ing cpu for global ownership of a boring cleanup cl

[Nico, 2015-04-30 19:06:56]

tbr'ing cpu for global ownership of a boring cleanup cl

[commit-bot: I haz the power, 2015-04-30 19:08:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1115293002/20001

[scheib, 2015-04-30 19:38:20]

scheib@chromium.org changed reviewers:
+ scheib@chromium.org

[scheib, 2015-04-30 19:38:20]

The boilerplate change descriptions here could have a bit more info than just
'plugin warnings', even the bug is pretty sparse and indirect on details.

[Nico, 2015-04-30 19:48:05]

See
https://www.chromium.org/developers/coding-style/chromium-style-checker-errors
for details
On Apr 30, 2015 12:38 PM, <scheib@chromium.org> wrote:

> The boilerplate change descriptions here could have a bit more info than
> just
> 'plugin warnings', even the bug is pretty sparse and indirect on details.
>
> https://codereview.chromium.org/1115293002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[scheib, 2015-04-30 19:55:16]

Thanks! I suggest changes like this include details/links like that explaining
the context.

[Nico, 2015-04-30 20:00:04]

On 2015/04/30 19:55:16, scheib wrote:
> Thanks! I suggest changes like this include details/links like that explaining
> the context.

For mass cleanups, the bug should provide context. It's possible we didn't do a
great job on that, I'll try to remember to add a comment there when I'm back at
my keyboard.

[commit-bot: I haz the power, 2015-04-30 20:07:59]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-30 20:08:48]

Patchset 2 (id:??) landed as
https://crrev.com/94b360568b3ea199c64312060a82477661624ea9
Cr-Commit-Position: refs/heads/master@{#327773}

[Nico, 2015-04-30 22:23:19]

Done: http://code.google.com/p/chromium/issues/detail?id=467287#c50

A bit hidden in the middle of that bug. Should've done that in comment 0, sorry!