[strong] Check arity of functions

test/mjsunit/strong/declaration-after-use.js

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Flags: --strong-mode --harmony_rest_parameters --harmony_arrow_functions --harmony_classes --harmony_computed-property_names
 
 // Note that it's essential for these tests that the reference is inside dead
 // code (because we already produce ReferenceErrors for run-time unresolved
 // variables and don't want to confuse those with strong mode errors). But the
 // errors should *not* be inside lazy, unexecuted functions, since lazy parsing
@@ skipping 193 matching lines @@
 
   function func1() { func1; this; }
   func1();
   func1;
 
   function * func2() { func2; this; }
   func2();
   func2;
 
   function func4(p, ...rest) { p; rest; this; func2; }
-  func4();
+  func4(1, 2); // FIXME

[rossberg, 2015/05/05 14:26:20]

Why FIXME?

[arv (Not doing code reviews), 2015/05/05 16:46:29]

Let me make that more explicit.

The arity checking is not correct when spread params are present. The number of
required arguments for func4 should be 1 and not 2.

 
   let func5 = (p1, p2) => { p1; p2; };
-  func5();
+  func5(1, 2);
 
   let func5b = p1 => p1;
-  func5b();
+  func5b(1);
 
   function func6() {
     var1, var2a, var2b, var2c;
   }
 
   class C1 { constructor() { C1; } }; new C1();
   let C2 = class C3 { constructor() { C3; } }; new C2();
 
   class C4 { method() { C4; } *generator_method() { C4; } }; new C4();
   let C5 = class C6 { method() { C6; } *generator_method() { C6; } }; new C5();
@@ skipping 18 matching lines @@
       }
       return new CInner();
     }
   }
   (new COuter()).m().n();
 
   // Making sure the check which is supposed to prevent "object literal inside
   // computed property name references the class name" is not too generic:
   class C14 { m() { let obj = { n() { C14 } }; obj.n(); } }; (new C14()).m();
 })();