Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 111523002: Sync cygwin version with chromium (Closed)

Created:
7 years ago by jochen (gone - plz use gerrit)
Modified:
7 years ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Visibility:
Public.

Description

Sync cygwin version with chromium 231940 - Set executable bit on third_party/cygwin/bin/dos2unix.exe 229213 - Add back module paths from old python_26 configuration. 228972 - Remove old python from path. 133786 - Add the svn:executable property to these .bat files LOG=n BUG=none R=machenbach@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18392

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
jochen (gone - plz use gerrit)
7 years ago (2013-12-10 10:35:03 UTC) #1
Jakob Kummerow
DBC: when you land this, please update https://code.google.com/p/v8/wiki/BuildingWithGYP#Prerequisites .
7 years ago (2013-12-10 12:13:13 UTC) #2
Michael Achenbach
lgtm
7 years ago (2013-12-10 15:15:52 UTC) #3
jochen (gone - plz use gerrit)
confirmed that it compiles and tests pass
7 years ago (2013-12-11 13:13:33 UTC) #4
jochen (gone - plz use gerrit)
7 years ago (2013-12-20 14:25:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r18392.

Powered by Google App Engine
This is Rietveld 408576698