base: Remove more use of MessageLoopProxy

base: Remove more use of MessageLoopProxy

Replace usage of MessageLoopProxy under base/prefs and
base/threading/sequenced_worker_pool with SingleThreadTaskRunner and
ThreadTaskRunnerHandle.

BUG=465354
Committed: https://crrev.com/9eb88f31c09e9fc61a6e3c654d2ab7c993d645ef
Cr-Commit-Position: refs/heads/master@{#328326}

[Sami, 2015-05-01 14:33:16]

skyostil@chromium.org changed reviewers:
+ danakj@chromium.org

[Sami, 2015-05-01 14:56:59]

Hi Dana, these are essentially the sharp bits pulled out of
https://codereview.chromium.org/1100773004/ -- I assume they're still okay?

I'll track down the remaining tests that fail with these changes and get them
fixed before landing.

[danakj, 2015-05-04 22:37:46]

LGTM

https://codereview.chromium.org/1115223003/diff/20001/base/prefs/pref_member.cc
File base/prefs/pref_member.cc (right):

https://codereview.chromium.org/1115223003/diff/20001/base/prefs/pref_member....
base/prefs/pref_member.cc:59: internal()->MoveToThread(task_runner);
nit: .Pass()

https://codereview.chromium.org/1115223003/diff/20001/base/threading/sequence...
File base/threading/sequenced_worker_pool.cc (right):

https://codereview.chromium.org/1115223003/diff/20001/base/threading/sequence...
base/threading/sequenced_worker_pool.cc:1177: DCHECK(constructor_task_runner_);
this dcheck probably not needed anymore.

[Sami, 2015-05-05 11:20:24]

Thanks!

https://codereview.chromium.org/1115223003/diff/20001/base/prefs/pref_member.cc
File base/prefs/pref_member.cc (right):

https://codereview.chromium.org/1115223003/diff/20001/base/prefs/pref_member....
base/prefs/pref_member.cc:59: internal()->MoveToThread(task_runner);
On 2015/05/04 22:37:46, danakj wrote:
> nit: .Pass()

Done.

https://codereview.chromium.org/1115223003/diff/20001/base/threading/sequence...
File base/threading/sequenced_worker_pool.cc (right):

https://codereview.chromium.org/1115223003/diff/20001/base/threading/sequence...
base/threading/sequenced_worker_pool.cc:1177: DCHECK(constructor_task_runner_);
On 2015/05/04 22:37:46, danakj wrote:
> this dcheck probably not needed anymore.

You're right, removed.

[Sami, 2015-05-05 12:54:44]

The CQ bit was checked by skyostil@chromium.org to run a CQ dry run

[Sami, 2015-05-05 12:54:45]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/1115223003/#ps60001
(title: "Fix nits.")

[commit-bot: I haz the power, 2015-05-05 12:55:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1115223003/60001

[commit-bot: I haz the power, 2015-05-05 14:30:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-05 14:30:31]

Dry run: This issue passed the CQ dry run.

[Sami, 2015-05-05 14:30:59]

The CQ bit was checked by skyostil@chromium.org

[commit-bot: I haz the power, 2015-05-05 14:31:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1115223003/60001

[commit-bot: I haz the power, 2015-05-05 14:35:24]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-05-05 14:36:53]

Patchset 4 (id:??) landed as
https://crrev.com/9eb88f31c09e9fc61a6e3c654d2ab7c993d645ef
Cr-Commit-Position: refs/heads/master@{#328326}