Add chrome.hid.getUserSelectedDevices API.

extensions/browser/api/hid/hid_device_manager.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_BROWSER_API_HID_HID_DEVICE_MANAGER_H_
 #define EXTENSIONS_BROWSER_API_HID_HID_DEVICE_MANAGER_H_
 
 #include <map>
 
 #include "base/basictypes.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/scoped_vector.h"
 #include "base/scoped_observer.h"
 #include "base/threading/thread_checker.h"
-#include "device/hid/hid_device_info.h"
 #include "device/hid/hid_service.h"
 #include "extensions/browser/browser_context_keyed_api_factory.h"
 #include "extensions/browser/event_router.h"
 #include "extensions/common/api/hid.h"
 
 namespace device {
 class HidDeviceFilter;
+class HidDeviceInfo;
 }
 
 namespace extensions {
 
 class Extension;
 
 // This service maps devices enumerated by device::HidService to resource IDs
 // returned by the chrome.hid API.
 class HidDeviceManager : public BrowserContextKeyedAPI,
                          public device::HidService::Observer,
@@ skipping 14 matching lines @@
   }
 
   // Enumerates available devices, taking into account the permissions held by
   // the given extension and the filters provided. The provided callback will
   // be posted to the calling thread's task runner with a list of device info
   // objects.
   void GetApiDevices(const Extension* extension,
                      const std::vector<device::HidDeviceFilter>& filters,
                      const GetApiDevicesCallback& callback);
 
+  // Converts a list of HidDeviceInfo objects into a value that can be returned
+  // through the API.
+  scoped_ptr<base::ListValue> GetApiDevicesFromList(
+      const std::vector<scoped_refptr<device::HidDeviceInfo>>& devices);
+
   scoped_refptr<device::HidDeviceInfo> GetDeviceInfo(int resource_id);
 
-  static bool HasPermission(const Extension* extension,
-                            scoped_refptr<device::HidDeviceInfo> device_info);
+  bool HasPermission(const Extension* extension,
+                     scoped_refptr<device::HidDeviceInfo> device_info,
+                     bool update_last_used);
 
  private:
   friend class BrowserContextKeyedAPIFactory<HidDeviceManager>;
 
   typedef std::map<int, device::HidDeviceId> ResourceIdToDeviceIdMap;
   typedef std::map<device::HidDeviceId, int> DeviceIdToResourceIdMap;
 
   struct GetApiDevicesParams;
 
   // KeyedService:
@@ skipping 24 matching lines @@
       const Extension* extension,
       const std::vector<device::HidDeviceFilter>& filters);
   void OnEnumerationComplete(
       const std::vector<scoped_refptr<device::HidDeviceInfo>>& devices);
 
   void DispatchEvent(const std::string& event_name,
                      scoped_ptr<base::ListValue> event_args,
                      scoped_refptr<device::HidDeviceInfo> device_info);
 
   base::ThreadChecker thread_checker_;
+  content::BrowserContext* browser_context_;
   EventRouter* event_router_;
-  bool initialized_;
+  bool initialized_ = false;

[Devlin, 2015/05/05 22:19:50]

please be consistent - if certain variables are going to be default-initialized,
they all should be.

[Reilly Grant (use Gerrit), 2015/05/06 00:52:53]

Done.

   ScopedObserver<device::HidService, device::HidService::Observer>
       hid_service_observer_;
-  bool enumeration_ready_;
+  bool enumeration_ready_ = false;
   ScopedVector<GetApiDevicesParams> pending_enumerations_;
-  int next_resource_id_;
+  int next_resource_id_ = 0;
   ResourceIdToDeviceIdMap device_ids_;
   DeviceIdToResourceIdMap resource_ids_;
   base::WeakPtrFactory<HidDeviceManager> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(HidDeviceManager);
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_BROWSER_API_HID_HID_DEVICE_MANAGER_H_