Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(77)

Issue 1115203003: De-virtualize media control painting methods (Closed)

Created:
5 years ago by Xianzhu
Modified:
5 years ago
Reviewers:
pdr., chrishtr
CC:
blink-reviews, blink-reviews-paint_chromium.org, dshwang, slimming-paint-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

De-virtualize media control painting methods They have the same implementations for all ThemePainter classes. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194792

Patch Set 1 #

Patch Set 2 : Mac doesn't want cast button #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -207 lines) Patch
M Source/core/paint/MediaControlsPainter.h View 2 chunks +10 lines, -3 lines 0 comments Download
M Source/core/paint/MediaControlsPainter.cpp View 12 chunks +12 lines, -53 lines 0 comments Download
M Source/core/paint/ThemePainter.h View 1 1 chunk +1 line, -17 lines 0 comments Download
M Source/core/paint/ThemePainter.cpp View 1 2 chunks +12 lines, -16 lines 0 comments Download
M Source/core/paint/ThemePainterDefault.h View 1 1 chunk +0 lines, -10 lines 0 comments Download
M Source/core/paint/ThemePainterDefault.cpp View 1 1 chunk +2 lines, -47 lines 0 comments Download
M Source/core/paint/ThemePainterMac.h View 1 chunk +0 lines, -10 lines 0 comments Download
M Source/core/paint/ThemePainterMac.mm View 2 chunks +0 lines, -51 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Xianzhu
**This is based on https://codereview.chromium.org/1102353008/**.
5 years ago (2015-04-30 17:24:49 UTC) #2
pdr.
lgtm
5 years ago (2015-04-30 17:29:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1115203003/1
5 years ago (2015-04-30 17:29:29 UTC) #5
Xianzhu
Not CQ-able for now. Must be after https://codereview.chromium.org/1102353008/.
5 years ago (2015-04-30 17:30:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1115203003/1
5 years ago (2015-05-01 01:12:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1115203003/20001
5 years ago (2015-05-01 03:42:42 UTC) #12
commit-bot: I haz the power
5 years ago (2015-05-01 07:30:44 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194792

Powered by Google App Engine
This is Rietveld 408576698