Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1115203002: DM+nanobench: print both current and max RSS. (Closed)

Created:
5 years, 7 months ago by mtklein_C
Modified:
5 years, 7 months ago
Reviewers:
rmistry, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

DM+nanobench: print both current and max RSS. out/Debug/dm: ( 360/380 MB 2112) 396ms gpu gm xfermodes out/Release/nanobench: 32/33 MB 1659 2.46µs 2.55µs 2.54µs 2.67µs 2% ▄▄▄▅▅▃▂▁▂█ gpu gradient_conicalZero_clamp_hicolor out/Debug/nanobench: 42/42 MB desk_css3gradients.skp_1 8888 BUG=skia: NOTREECHECKS=true Committed: https://skia.googlesource.com/skia/+/d75c466ef57ef4dbdf96390b2c01121e4de36f23

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -19 lines) Patch
M bench/nanobench.cpp View 5 chunks +9 lines, -7 lines 0 comments Download
M dm/DM.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M tools/ProcStats.h View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
mtklein_C
Can't hurt to have more memory information while we're looking at those sp SKPs.
5 years, 7 months ago (2015-04-30 14:06:54 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1115203002/1
5 years, 7 months ago (2015-04-30 14:07:12 UTC) #4
rmistry
LGTM
5 years, 7 months ago (2015-04-30 14:09:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1115203002/1
5 years, 7 months ago (2015-04-30 14:11:01 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 14:11:27 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d75c466ef57ef4dbdf96390b2c01121e4de36f23

Powered by Google App Engine
This is Rietveld 408576698