Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1115193002: Mark tests as NeedsManualRebaseline after V8 roll (Closed)

Created:
5 years, 7 months ago by kozy
Modified:
5 years, 7 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Mark tests as NeedsManualRebaseline after V8 roll BUG=480652 TBR=pfeldman@chromium.org,machenbach@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194739

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
kozy
5 years, 7 months ago (2015-04-30 13:40:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1115193002/1
5 years, 7 months ago (2015-04-30 13:40:40 UTC) #3
Michael Achenbach
Please also add virtual/pointerevent/fast/events/window-onerror-04.html That seems to fail on linux: http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2064%20%28dbg%29/builds/2680 Maybe it doesn't run ...
5 years, 7 months ago (2015-04-30 13:45:56 UTC) #4
Michael Achenbach
I meant virtual/slimmingpaint/fast/events/window-onerror-04.html
5 years, 7 months ago (2015-04-30 13:51:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1115193002/20001
5 years, 7 months ago (2015-04-30 13:52:18 UTC) #8
Michael Achenbach
lgtm
5 years, 7 months ago (2015-04-30 13:55:56 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 14:07:20 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194739

Powered by Google App Engine
This is Rietveld 408576698