Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1115173004: [Android] Rename ChromeNativeTest* to NativeTest*. (Closed)

Created:
5 years, 7 months ago by jbudorick
Modified:
5 years, 7 months ago
Reviewers:
cjhopman, Yaron
CC:
chromium-reviews, klundberg+watch_chromium.org, erikwright+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Rename ChromeNativeTest* to NativeTest*. ChromeNativeTest* implies that these files can use and are designed for //chrome, which is not the case. BUG= Committed: https://crrev.com/575a2608e3843ded80d91e11c027fc464477cc5a Cr-Commit-Position: refs/heads/master@{#327876}

Patch Set 1 #

Patch Set 2 : switch to org.chromium.base.Log #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -362 lines) Patch
M base/android/java/templates/NativeLibraries.template View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/constants/__init__.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/gtest/local_device_gtest_run.py View 1 chunk +2 lines, -2 lines 0 comments Download
M build/android/pylib/gtest/test_package_apk.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/remote/device/remote_device_gtest_run.py View 3 chunks +4 lines, -4 lines 0 comments Download
M build/config/android/rules.gni View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/android/unit_tests_apk/AndroidManifest.xml View 2 chunks +4 lines, -4 lines 0 comments Download
M testing/android/native_test.gyp View 1 chunk +1 line, -1 line 0 comments Download
M testing/android/native_test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M testing/android/native_test/java/AndroidManifest.xml View 2 chunks +4 lines, -4 lines 0 comments Download
D testing/android/native_test/java/src/org/chromium/native_test/ChromeNativeTestActivity.java View 1 chunk +0 lines, -124 lines 0 comments Download
D testing/android/native_test/java/src/org/chromium/native_test/ChromeNativeTestInstrumentationTestRunner.java View 1 chunk +0 lines, -185 lines 0 comments Download
A + testing/android/native_test/java/src/org/chromium/native_test/NativeTestActivity.java View 1 4 chunks +9 lines, -9 lines 0 comments Download
A + testing/android/native_test/java/src/org/chromium/native_test/NativeTestInstrumentationTestRunner.java View 1 7 chunks +22 lines, -22 lines 0 comments Download
M testing/android/native_test/native_test_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
jbudorick
cjhopman: I should really just listen to you to begin with https://codereview.chromium.org/804753005/#msg10
5 years, 7 months ago (2015-04-30 20:50:37 UTC) #2
cjhopman
lgtm. :)
5 years, 7 months ago (2015-04-30 20:57:53 UTC) #3
Yaron
lgtm
5 years, 7 months ago (2015-04-30 21:01:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1115173004/1
5 years, 7 months ago (2015-04-30 21:38:55 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/60381)
5 years, 7 months ago (2015-04-30 21:48:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1115173004/20001
5 years, 7 months ago (2015-05-01 01:48:25 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-01 04:08:37 UTC) #12
commit-bot: I haz the power
5 years, 7 months ago (2015-05-01 04:09:33 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/575a2608e3843ded80d91e11c027fc464477cc5a
Cr-Commit-Position: refs/heads/master@{#327876}

Powered by Google App Engine
This is Rietveld 408576698