Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1295)

Issue 1115113002: Adding DCHECK for CurrentlyOn(BrowserThread::IO) (Closed)

Created:
5 years, 7 months ago by anujsharma
Modified:
5 years, 7 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org, rpetterson
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding DCHECK for CurrentlyOn(BrowserThread::IO) Fixing the below TODO: TODO(rlp): Add DCHECK for CurrentlyOn(BrowserThread::IO) when the ProfileManagerTest has been updated with a mock profile. BUG=None Committed: https://crrev.com/b611ff37a166f2479a3ff7686de09baf92ec893a Cr-Commit-Position: refs/heads/master@{#327894}

Patch Set 1 #

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/net/predictor.cc View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
anujsharma
PTAL
5 years, 7 months ago (2015-04-30 09:41:38 UTC) #2
Ryan Sleevi
lgtm
5 years, 7 months ago (2015-04-30 16:32:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1115113002/20001
5 years, 7 months ago (2015-05-01 06:49:20 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-01 08:33:39 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-01 08:34:33 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b611ff37a166f2479a3ff7686de09baf92ec893a
Cr-Commit-Position: refs/heads/master@{#327894}

Powered by Google App Engine
This is Rietveld 408576698