Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Issue 1115073002: Check for NULL familyName in SkFontMgr_fontconfig. (Closed)

Created:
5 years, 7 months ago by bungeman-skia
Modified:
5 years, 7 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Check for NULL familyName in SkFontMgr_fontconfig. If the familyName is NULL, don't bother spending time trying to add it to the FcPattern. Committed: https://skia.googlesource.com/skia/+/6837b38a62a1621ff43c7e1085b1a3bd208fcd49

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M src/ports/SkFontMgr_fontconfig.cpp View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
bungeman-skia
Simple test for performance and to avoid possible issues down the road. (I think it ...
5 years, 7 months ago (2015-04-29 21:24:17 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1115073002/1
5 years, 7 months ago (2015-04-29 21:25:28 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-04-29 21:29:05 UTC) #6
reed1
lgtm
5 years, 7 months ago (2015-04-29 21:35:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1115073002/1
5 years, 7 months ago (2015-04-29 21:35:35 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 21:35:54 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6837b38a62a1621ff43c7e1085b1a3bd208fcd49

Powered by Google App Engine
This is Rietveld 408576698