Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 1115063002: win: wstring->string16 in chrome/installer/util/html_dialog (Closed)

Created:
5 years, 7 months ago by Nico
Modified:
5 years, 7 months ago
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

win: wstring->string16 in chrome/installer/util/html_dialog No intended behavior change. Presubmit complained about this one in https://codereview.chromium.org/1109043003/ BUG=23581 Committed: https://crrev.com/6ef2bd1f9dc88633e07c44620bc8afb804b8a4b6 Cr-Commit-Position: refs/heads/master@{#327602}

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -13 lines) Patch
M chrome/installer/util/html_dialog.h View 1 3 chunks +5 lines, -4 lines 2 comments Download
M chrome/installer/util/html_dialog_impl.cc View 1 3 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Nico
(will likely have merge conflicts with dcheng's CL; I'll wait for that to land and ...
5 years, 7 months ago (2015-04-29 19:34:10 UTC) #2
Lei Zhang
lgtm
5 years, 7 months ago (2015-04-29 20:44:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1115063002/20001
5 years, 7 months ago (2015-04-29 21:52:45 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-04-29 22:50:30 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/6ef2bd1f9dc88633e07c44620bc8afb804b8a4b6 Cr-Commit-Position: refs/heads/master@{#327602}
5 years, 7 months ago (2015-04-29 22:51:19 UTC) #10
grt (UTC plus 2)
Thanks for the cleanup CL. The stale inclusion of <string> can be removed now, no? ...
5 years, 7 months ago (2015-04-30 02:58:29 UTC) #12
Nico
5 years, 7 months ago (2015-04-30 02:59:20 UTC) #13
Message was sent while issue was closed.
https://codereview.chromium.org/1115063002/diff/20001/chrome/installer/util/h...
File chrome/installer/util/html_dialog.h (right):

https://codereview.chromium.org/1115063002/diff/20001/chrome/installer/util/h...
chrome/installer/util/html_dialog.h:8: #include <string>
On 2015/04/30 02:58:29, grt wrote:
> remove

string16.h includes <string>, but yeah I guess it's a bit nicer. I'll send you a
patch.

Powered by Google App Engine
This is Rietveld 408576698