Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 1115043005: Revert of Remove the weak list of array buffers (Closed)

Created:
5 years, 7 months ago by Michael Achenbach
Modified:
5 years, 7 months ago
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Remove the weak list of array buffers (patchset #8 id:140001 of https://codereview.chromium.org/1114563002/) Reason for revert: [Sheriff] Crashes in layout tests: https://chromegw.corp.google.com/i/client.v8/builders/V8-Blink%20Linux%2064%20%28dbg%29/builds/2668 Original issue's description: > Remove the weak list of array buffers > > Instead, collect live array buffers during marking and free pointers we > no longer found. > > BUG=v8:3996 > R=hpayer@chromium.org > LOG=n > > Committed: https://crrev.com/2d39709cf5ee17637f6f2d75380a9e61ae0b342b > Cr-Commit-Position: refs/heads/master@{#28132} TBR=dslomov@chromium.org,hpayer@chromium.org,jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3996 Committed: https://crrev.com/3e25666c79373789bf020a2f9ef4be5e8d96dc6c Cr-Commit-Position: refs/heads/master@{#28148}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+277 lines, -66 lines) Patch
M src/api.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/heap-snapshot-generator.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap/heap.h View 6 chunks +13 lines, -9 lines 0 comments Download
M src/heap/heap.cc View 3 chunks +38 lines, -37 lines 0 comments Download
M src/heap/mark-compact.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/heap/objects-visiting.h View 1 chunk +4 lines, -1 line 0 comments Download
M src/heap/objects-visiting.cc View 5 chunks +40 lines, -5 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 2 chunks +9 lines, -5 lines 0 comments Download
M src/objects.h View 2 chunks +5 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/runtime/runtime-typedarray.cc View 4 chunks +31 lines, -3 lines 0 comments Download
M src/snapshot/serialize.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A test/cctest/test-weaktypedarrays.cc View 1 chunk +124 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of Remove the weak list of array buffers
5 years, 7 months ago (2015-04-30 08:38:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1115043005/1
5 years, 7 months ago (2015-04-30 08:38:10 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-30 08:38:24 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 08:38:35 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3e25666c79373789bf020a2f9ef4be5e8d96dc6c
Cr-Commit-Position: refs/heads/master@{#28148}

Powered by Google App Engine
This is Rietveld 408576698