Handle currently bound texture id in PowerVR workaround

Handle currently bound texture id in PowerVR workaround

If the texture id being deleted is currently bound to target, make sure
the new texture is bound to target. ScopedTextureBinder will then do the
right thing and restore the new texture id as bound on destruction.

BUG=480992
Committed: https://crrev.com/cbaf2c4519a53edee3db309434eee9d4161fe11d
Cr-Commit-Position: refs/heads/master@{#327614}

[boliu, 2015-04-29 20:43:08]

boliu@chromium.org changed reviewers:
+ sievers@chromium.org

[boliu, 2015-04-29 20:43:08]

something like this?

I couldn't get the bind to actually execute, because all the textures being
updated are not currently bound.

[no sievers, 2015-04-29 21:04:43]

https://codereview.chromium.org/1115043003/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/texture_definition.cc (right):

https://codereview.chromium.org/1115043003/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/texture_definition.cc:416: glGetIntegerv(target_,
&bound_id);
This doesn't work. It will generate a GL error I assume.

You can just DCHECK_EQ(GL_TEXTURE2D, target_); and then do:
glGetIntegerv(GL_TEXTURE_BINDING_2D, &bound_id);

[boliu, 2015-04-29 21:16:14]

https://codereview.chromium.org/1115043003/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/texture_definition.cc (right):

https://codereview.chromium.org/1115043003/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/texture_definition.cc:416: glGetIntegerv(target_,
&bound_id);
On 2015/04/29 21:04:43, sievers wrote:
> This doesn't work. It will generate a GL error I assume.
> 
> You can just DCHECK_EQ(GL_TEXTURE2D, target_); and then do:
> glGetIntegerv(GL_TEXTURE_BINDING_2D, &bound_id);

Meh, missed the giant block doing the GL_TEXTURE2D -> GL_TEXTURE_BINDING_2D in
ScopedTextureBinder. Done

Surprised there isn't already a helper function to do that though..

[no sievers, 2015-04-29 21:49:54]

lgtm

[boliu, 2015-04-29 22:14:06]

The CQ bit was checked by boliu@chromium.org

[commit-bot: I haz the power, 2015-04-29 22:14:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1115043003/20001

[commit-bot: I haz the power, 2015-04-29 23:28:34]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-29 23:30:35]

Patchset 2 (id:??) landed as
https://crrev.com/cbaf2c4519a53edee3db309434eee9d4161fe11d
Cr-Commit-Position: refs/heads/master@{#327614}