Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: components/BUILD.gn

Issue 1115033003: resources: Prevent including the same resource in multiple pack files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: tot-merge Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/base/javascript_browser_test.cc ('k') | components/components_tests.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/BUILD.gn
diff --git a/components/BUILD.gn b/components/BUILD.gn
index 1f19490067cfcf18a9bb0ef29080c1d27cc2f1ec..700e862fdf8b42af5a87be903587765d9377c2e5 100644
--- a/components/BUILD.gn
+++ b/components/BUILD.gn
@@ -298,6 +298,7 @@ test("components_unittests") {
"//content/test:test_support",
"//net",
"//ui/base",
+ "//ui/resources:ui_test_pak",
]
data_deps = [ ":components_tests_pak" ]
@@ -331,10 +332,6 @@ repack("components_tests_pak") {
sources = [
"$root_gen_dir/components/components_resources.pak",
"$root_gen_dir/components/strings/components_strings_en-US.pak",
- "$root_gen_dir/ui/resources/ui_resources_100_percent.pak",
- "$root_gen_dir/ui/resources/webui_resources.pak",
- "$root_gen_dir/ui/strings/app_locale_settings_en-US.pak",
- "$root_gen_dir/ui/strings/ui_strings_en-US.pak",
]
output = "$root_out_dir/components_tests_resources.pak"
@@ -342,8 +339,6 @@ repack("components_tests_pak") {
deps = [
"//components/resources",
"//components/strings",
- "//ui/resources",
- "//ui/strings",
]
}
« no previous file with comments | « chrome/test/base/javascript_browser_test.cc ('k') | components/components_tests.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698