resources: Prevent including the same resource in multiple pack files.

ash/test/ash_test_helper.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/test/ash_test_helper.h"
 
 #include "ash/accelerators/accelerator_controller.h"
 #include "ash/ash_switches.h"
 #include "ash/shell.h"
 #include "ash/shell_init_params.h"
@@ skipping 108 matching lines @@
 
   // Remove global message center state.
   message_center::MessageCenter::Shutdown();
 
 #if defined(OS_CHROMEOS)
   chromeos::CrasAudioHandler::Shutdown();
   if (dbus_thread_manager_initialized_) {
     chromeos::DBusThreadManager::Shutdown();
     dbus_thread_manager_initialized_ = false;
   }
-  keyboard::ResetKeyboardForTesting();

[Nico, 2015/05/02 00:50:48]

?

[sadrul, 2015/05/02 04:17:09]

A new instance of ash::Shell gets created for each test, and it initializes the
virtual keyboard upon creation. The virtual keyboard installs the resource-pak
to the resource-bundle when it is initialized. However, the resource-bundle is
initialized only once for the entire test-suite. This trips the new check, since
the same resource-pak is attempted to load multiple times. So for the ash tests,
the keyboard is reset with the resource-bundle, so that the virtual keyboard
initialization does not attempt to load the resource-pak for each test.

[Nico, 2015/05/06 01:06:35]

I would've guessed that the intention of this is that the virtual keyboard is
dismissed after each test if it's open. With this change, it's only dismissed
once at the end of all tests.

Maybe it's good to land this separately and have someone familiar with the
virtual keyboard review it.

 #endif
 
   aura::Env::DeleteInstance();
   ui::TerminateContextFactoryForTests();
 
   // Need to reset the initial login status.
   TestSystemTrayDelegate::SetInitialLoginStatus(user::LOGGED_IN_USER);
 
   ui::ShutdownInputMethodForTesting();
   zero_duration_mode_.reset();
@@ skipping 38 matching lines @@
 bool AshTestHelper::SupportsHostWindowResize() {
 #if defined(OS_WIN)
   return false;
 #else
   return true;
 #endif
 }
 
 }  // namespace test
 }  // namespace ash