Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Issue 111503008: Fix some presubmit warnings. (Closed)

Created:
7 years ago by tfarina
Modified:
7 years ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Fix some presubmit warnings. I found this while running a modified version of v8's tools/presubmit.py script. samplecode/SampleImage.cpp does not end with a single new line. samplecode/SampleImageDir.cpp does not end with a single new line. src/ports/SkFontHost_sandbox_none.cpp does not end with a single new line. tests/FlatDataTest.cpp does not end with a single new line. tests/ImageCacheTest.cpp has trailing whitespaces in line 31. * Removed three empty files. * Add single new line to FlatDataTest.cpp * Removed trailing whitespace in ImageCacheTest.cpp BUG=None TEST=None R=bsalomon@google.com TBR=bsalomon@google.com Committed: https://code.google.com/p/skia/source/detail?r=12684

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-2 lines, --1 lines) Patch
D samplecode/SampleImage.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
D samplecode/SampleImageDir.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
D src/ports/SkFontHost_sandbox_none.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/FlatDataTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/ImageCacheTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
tfarina
tiny cleanup...pushing to cq!
7 years ago (2013-12-14 01:31:59 UTC) #1
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years ago (2013-12-14 01:32:12 UTC) #2
bsalomon
lgtm
7 years ago (2013-12-14 14:58:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tfarina@chromium.org/111503008/1
7 years ago (2013-12-14 14:58:49 UTC) #4
tfarina
7 years ago (2013-12-14 15:12:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r12684 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698