Issue 111503003: dom_distiller_core exports dependent settings of distilled_page_proto

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 111503003: dom_distiller_core exports dependent settings of distilled_page_proto (Closed)

Created:
7 years ago by blundell

Modified:
7 years ago

Reviewers:
cjhopman

CC:
chromium-reviews, noyau (Ping after 24h), Yaron, nyquist, bengr

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

dom_distiller_core exports dependent settings of distilled_page_proto distilled_page_proto generates a header that dom_distiller_core includes in its public headers. Thus, dom_distiller_core needs to export distilled_page_proto's hard dependency to any target depending on dom_distiller_core; otherwise, those targets are subject to flaky build failures. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240443

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	chrome/chrome_browser_ui.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	components/dom_distiller.gypi	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/111503003/1

7 years ago (2013-12-12 19:31:23 UTC) #4

Message was sent while issue was closed.

Change committed as 240443

Expand Messages | Collapse Messages