Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(45)

Issue 11150013: Fix wrong truncation of notification popup messages in ash. (Closed)

Created:
6 years, 1 month ago by kinaba
Modified:
6 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, Alexei Svitkine (slow)
Visibility:
Public.

Description

Fix wrong truncation of notification popup messages in ash. views::Label control first calculates the size of the text, and then tries to render the text in the exact size of rectangle. If < is used instead of <= in the patched line, the control flows to the BreakIterator mode, that sometimes computes a larger width value and causes truncation. BUG=155663 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=162308

Patch Set 1 #

Patch Set 2 : Added a testcase. #

Patch Set 3 : Disable the test for Android.wq #

Patch Set 4 : Withdraw the not so effective tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/base/text/text_elider.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
kinaba
asvitkine@, according git-blame you looks to be the expert around here. Could you take a ...
6 years, 1 month ago (2012-10-15 08:22:33 UTC) #1
Alexei Svitkine (slow)
On 2012/10/15 08:22:33, kinaba wrote: > asvitkine@, according git-blame you looks to be the expert ...
6 years, 1 month ago (2012-10-15 15:57:15 UTC) #2
sky
Please add some test coverage.
6 years, 1 month ago (2012-10-15 22:57:16 UTC) #3
kinaba
On 2012/10/15 22:57:16, sky wrote: > Please add some test coverage. Done--though it won't always ...
6 years, 1 month ago (2012-10-16 06:52:29 UTC) #4
sky
If the unit test doesn't give coverage, nuke it. LGTM
6 years, 1 month ago (2012-10-16 16:07:39 UTC) #5
kinaba
On 2012/10/16 16:07:39, sky wrote: > If the unit test doesn't give coverage, nuke it. ...
6 years, 1 month ago (2012-10-17 01:20:37 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2012-10-17 01:20:50 UTC) #7

Powered by Google App Engine
This is Rietveld 408576698