Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(824)

Issue 1114993002: Add a message loop to TabControllerTest (Closed)

Created:
5 years, 7 months ago by Sami
Modified:
5 years, 7 months ago
Reviewers:
msw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a message loop to TabControllerTest This makes it possible to later migrate base/ from MessageLoopProxy over to ThreadTaskRunnerHandle, which requires an active task runner on the current thread. TBR=msw@chromium.org BUG=465354 Committed: https://crrev.com/4265822a06571e85a26c659ea93186243c8f8e10 Cr-Commit-Position: refs/heads/master@{#327496}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/tabs/tab_controller_unittest.mm View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1114993002/1
5 years, 7 months ago (2015-04-29 15:32:15 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 15:42:35 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4265822a06571e85a26c659ea93186243c8f8e10 Cr-Commit-Position: refs/heads/master@{#327496}
5 years, 7 months ago (2015-04-29 15:43:31 UTC) #4
msw
Why does this test need a MessageLoop? I don't see any calls to post tasks ...
5 years, 7 months ago (2015-04-29 17:21:05 UTC) #5
Sami
On 2015/04/29 17:21:05, msw wrote: > Why does this test need a MessageLoop? I don't ...
5 years, 7 months ago (2015-04-29 17:34:53 UTC) #6
msw
5 years, 7 months ago (2015-04-29 17:36:23 UTC) #7
Message was sent while issue was closed.
rubber stamp lgtm

Powered by Google App Engine
This is Rietveld 408576698