Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 1114903002: [test] Turn compiler/test-node-cache into a unit test. (Closed)

Created:
5 years, 7 months ago by Michael Starzinger
Modified:
5 years, 7 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-test-node-algorithm
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Turn compiler/test-node-cache into a unit test. R=jarin@chromium.org TEST=unittests/NodeCacheTest Committed: https://crrev.com/4bc2beab97b9e8e3b4a423c78a97b6130407a0ca Cr-Commit-Position: refs/heads/master@{#28136}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -176 lines) Patch
M test/cctest/cctest.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D test/cctest/compiler/test-node-cache.cc View 1 chunk +0 lines, -175 lines 0 comments Download
A test/unittests/compiler/node-cache-unittest.cc View 1 chunk +159 lines, -0 lines 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
5 years, 7 months ago (2015-04-29 11:20:25 UTC) #1
Jarin
lgtm
5 years, 7 months ago (2015-04-29 13:58:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1114903002/1
5 years, 7 months ago (2015-04-29 14:24:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 14:40:01 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 14:40:16 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4bc2beab97b9e8e3b4a423c78a97b6130407a0ca
Cr-Commit-Position: refs/heads/master@{#28136}

Powered by Google App Engine
This is Rietveld 408576698