base/memory/scoped_ptr_unittest.cc - Issue 11149006: Extend scoped_ptr to be closer to unique_ptr. Support custom deleters, and deleting arrays.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/memory/scoped_ptr_unittest.cc

Issue 11149006: Extend scoped_ptr to be closer to unique_ptr. Support custom deleters, and deleting arrays. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: I think this works. Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/memory/scoped_ptr_unittest.cc

diff --git a/base/memory/scoped_ptr_unittest.cc b/base/memory/scoped_ptr_unittest.cc

index 3da6f15273181070fa51cc25107708def2fffa1f..e43b0b9f6964e192b71196057a04378600a5356b 100644

--- a/base/memory/scoped_ptr_unittest.cc

+++ b/base/memory/scoped_ptr_unittest.cc

@@ -348,7 +348,7 @@ TEST(ScopedPtrTest, PassAs) {

EXPECT_TRUE(scoper.get());

scoped_ptr<ConDecLoggerParent> scoper_parent;

- scoper_parent = UpcastUsingPassAs(scoper.Pass());

+// scoper_parent = UpcastUsingPassAs(scoper.Pass());

EXPECT_EQ(1, constructed);

EXPECT_TRUE(scoper_parent.get());

EXPECT_FALSE(scoper.get());

« base/memory/scoped_ptr.h ('K') | « base/memory/scoped_ptr.h ('k') | no next file » | no next file with comments »