Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Issue 1114883002: Use of base::StringPairs appropriately in disk_cache (Closed)

Created:
5 years, 7 months ago by payal.pandey
Modified:
5 years, 7 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use of base::StringPairs appropriately in disk_cache Bescause base/strings/string_split.h defines: typedef std::vector<std::pair<std::string, std::string> > StringPairs; BUG=412250 Committed: https://crrev.com/b256c74a4dc38cd5bf579bb87909b19a1cee9374 Cr-Commit-Position: refs/heads/master@{#327675}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M net/disk_cache/disk_cache.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
payal.pandey
Please have a look, Thanks.
5 years, 7 months ago (2015-04-29 10:37:19 UTC) #2
eroman
Please also update the overrides of this method. Notably: https://code.google.com/p/chromium/codesearch#chromium/src/net/disk_cache/disk_cache.h&sq=package:chromium&dr=CSs&rcl=1430322214&l=152 https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/cache_storage/cache_storage_cache_unittest.cc&l=93 https://code.google.com/p/chromium/codesearch#chromium/src/net/disk_cache/memory/mem_backend_impl.h&l=83 https://code.google.com/p/chromium/codesearch#chromium/src/net/disk_cache/simple/simple_backend_impl.cc&l=547 https://code.google.com/p/chromium/codesearch#chromium/src/net/disk_cache/simple/simple_backend_impl.h&l=108 https://code.google.com/p/chromium/codesearch#chromium/src/net/http/mock_http_cache.cc&l=486 ...
5 years, 7 months ago (2015-04-29 19:09:06 UTC) #3
payal.pandey
On 2015/04/29 19:09:06, eroman wrote: > Please also update the overrides of this method. Notably: ...
5 years, 7 months ago (2015-04-29 19:24:09 UTC) #4
eroman
lgtm
5 years, 7 months ago (2015-04-29 19:31:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1114883002/1
5 years, 7 months ago (2015-04-30 06:26:31 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-30 07:36:09 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 07:37:03 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b256c74a4dc38cd5bf579bb87909b19a1cee9374
Cr-Commit-Position: refs/heads/master@{#327675}

Powered by Google App Engine
This is Rietveld 408576698