Issue 1114863003: cc: Make LTHI::LayerTreeSettings const

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1114863003: cc: Make LTHI::LayerTreeSettings const (Closed)

Created:
5 years, 7 months ago by enne (OOO)

Modified:
5 years, 7 months ago

Reviewers:
danakj, vmpstr

CC:
cc-bugs_chromium.org, chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

cc: Make LTHI::LayerTreeSettings const No code expects these settings to change and has no way to react to these changes. It's treated as const everywhere, so we should just make it const. R=danakj@chromium.org,vmpstr@chromium.org Committed: https://crrev.com/65dc6219e497328d828f790b35d2c0cec287b16e Cr-Commit-Position: refs/heads/master@{#327575}

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	cc/trees/layer_tree_host_impl.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 7 (1 generated)

enne (OOO)

Also it turns out that LTH::settings_ is already const. Who knew?

5 years, 7 months ago (2015-04-29 19:53:23 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1114863003/1

5 years, 7 months ago (2015-04-29 19:53:54 UTC) #5

commit-bot: I haz the power

5 years, 7 months ago (2015-04-29 21:46:09 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/65dc6219e497328d828f790b35d2c0cec287b16e
Cr-Commit-Position: refs/heads/master@{#327575}