Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1114843004: Use of base::StringPairs appropriately in net/test/embedded_test_server/http_response.h (Closed)

Created:
5 years, 7 months ago by payal.pandey
Modified:
5 years, 7 months ago
Reviewers:
mtomasz, eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use of base::StringPairs appropriately in net/test/embedded_test_server/http_response.h Bescause base/strings/string_split.h defines: typedef std::vector<std::pair<std::string, std::string> > StringPairs; BUG=412250 Committed: https://crrev.com/2bc4abe685d396e5979c3f3fed80c1574ebe5dd2 Cr-Commit-Position: refs/heads/master@{#327570}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M net/test/embedded_test_server/http_response.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
payal.pandey
Please have a look, Thanks.
5 years, 7 months ago (2015-04-29 09:51:27 UTC) #2
eroman
lgtm
5 years, 7 months ago (2015-04-29 19:32:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1114843004/1
5 years, 7 months ago (2015-04-29 20:31:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 21:40:18 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 21:41:26 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2bc4abe685d396e5979c3f3fed80c1574ebe5dd2
Cr-Commit-Position: refs/heads/master@{#327570}

Powered by Google App Engine
This is Rietveld 408576698