Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 1114823002: [chrome/browser/metrices] Replace MessageLoopProxy usage with ThreadTaskRunnerHandle (Closed)

Created:
5 years, 7 months ago by Pranay
Modified:
5 years, 7 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org, anujsharma
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace MessageLoopProxy usage with ThreadTaskRunnerHandle in chrome/browser/metrices module. MessageLoopProxy is deprecated. This basically does a search and replace of: MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get(). MessageLoopProxy -> SingleThreadTaskRunner BUG=391045 Committed: https://crrev.com/ddded40c2a74d1216ef43f6fba809d3ee45d9cfa Cr-Commit-Position: refs/heads/master@{#327667}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M chrome/browser/metrics/plugin_metrics_provider.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/metrics/thread_watcher.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/metrics/thread_watcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Pranay
PTAL Thanks
5 years, 7 months ago (2015-04-29 06:25:41 UTC) #2
Ilya Sherman
LGTM
5 years, 7 months ago (2015-04-30 05:07:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1114823002/1
5 years, 7 months ago (2015-04-30 05:08:08 UTC) #5
Pranay
Thanks :)
5 years, 7 months ago (2015-04-30 05:08:23 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-30 07:05:55 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 07:06:56 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ddded40c2a74d1216ef43f6fba809d3ee45d9cfa
Cr-Commit-Position: refs/heads/master@{#327667}

Powered by Google App Engine
This is Rietveld 408576698