Issue 11148031: webkit: Check that delegate_ isn't NULL before trying to updateGeometry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11148031: webkit: Check that delegate_ isn't NULL before trying to updateGeometry. (Closed)

Created:
8 years, 2 months ago by sadrul

Modified:
8 years, 2 months ago

Reviewers:
Bernhard Bauer

CC:
chromium-reviews, darin-cc_chromium.org, abarth-chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

webkit: Check that delegate_ isn't NULL before trying to updateGeometry. It appears that paint() checks for non-NULL delegate_, so it makes sense to do the same for updateGeometry as well. BUG=155950 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=162262

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	webkit/plugins/npapi/webplugin_impl.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

I'm not the right person to review this change. Perhaps someone in the OWNERS file ...

8 years, 2 months ago (2012-10-15 21:50:15 UTC) #2

lgtm

Expand Messages | Collapse Messages