Mac: App menuBars: Ignore closing windows if they are not main

chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac_browsertest.mm

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac.h"
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/command_line.h"
-#include "base/mac/scoped_nsobject.h"
+#import "base/mac/foundation_util.h"
+#import "base/mac/scoped_nsobject.h"
+#import "base/mac/scoped_objc_class_swizzler.h"
 #include "base/strings/sys_string_conversions.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/apps/app_browsertest_util.h"
 #include "chrome/browser/apps/app_shim/extension_app_shim_handler_mac.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/launch_util.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser_iterator.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/common/chrome_switches.h"
 #include "extensions/browser/app_window/app_window_registry.h"
 #include "extensions/browser/app_window/native_app_window.h"
 #include "extensions/browser/uninstall_reason.h"
 #include "extensions/common/extension.h"
 #include "extensions/test/extension_test_message_listener.h"
 
+// Donates a testing implementation of [NSWindow isMainWindow].
+@interface IsMainWindowDonorForWindow : NSObject
+@end
+
 namespace {
 
+// Simulates a particular NSWindow to report YES for [NSWindow isMainWindow].
+// This allows test coverage of code relying on window focus changes without
+// resorting to an interactive_ui_test.
+class ScopedFakeWindowMainStatus {
+ public:
+  ScopedFakeWindowMainStatus(NSWindow* window)
+      : swizzler_([NSWindow class],
+                  [IsMainWindowDonorForWindow class],
+                  @selector(isMainWindow)) {
+    DCHECK(!window_);
+    window_ = window;
+  }
+
+  ~ScopedFakeWindowMainStatus() { window_ = nil; }
+
+  static NSWindow* GetMainWindow() { return window_; }
+
+ private:
+  static NSWindow* window_;
+  base::mac::ScopedObjCClassSwizzler swizzler_;
+
+  DISALLOW_COPY_AND_ASSIGN(ScopedFakeWindowMainStatus);
+};
+
+NSWindow* ScopedFakeWindowMainStatus::window_ = nil;
+
 class AppShimMenuControllerBrowserTest
     : public extensions::PlatformAppBrowserTest {
  protected:
   // The apps that can be installed and launched by SetUpApps().
   enum AvailableApps { PACKAGED_1 = 0x1, PACKAGED_2 = 0x2, HOSTED = 0x4 };
 
   AppShimMenuControllerBrowserTest()
       : app_1_(nullptr),
         app_2_(nullptr),
         hosted_app_(nullptr),
@@ skipping 124 matching lines @@
   // When an app window is closed and there are no other app windows, the menu
   // items for the app should be removed.
   app_1_app_window->GetBaseWindow()->Close();
   chrome_window->Close();
   [[NSNotificationCenter defaultCenter]
       postNotificationName:NSWindowWillCloseNotification
                     object:app_2_app_window->GetNativeWindow()];
   CheckNoAppMenus();
 }
 
+// Test that closing windows without main status do not update the menu.
+IN_PROC_BROWSER_TEST_F(AppShimMenuControllerBrowserTest,
+                       ClosingBackgroundWindowLeavesMenuBar) {
+  // Start with app1 active.
+  SetUpApps(PACKAGED_1);
+  extensions::AppWindow* app_1_app_window = FirstWindowForApp(app_1_);
+  ScopedFakeWindowMainStatus app_1_is_main(app_1_app_window->GetNativeWindow());
+
+  [[NSNotificationCenter defaultCenter]
+      postNotificationName:NSWindowDidBecomeMainNotification
+                    object:app_1_app_window->GetNativeWindow()];
+  CheckHasAppMenus(app_1_);
+
+  // Closing a background window without focusing it should not change menus.
+  BrowserWindow* chrome_window = chrome::BrowserIterator()->window();
+  chrome_window->Close();
+  [[NSNotificationCenter defaultCenter]
+      postNotificationName:NSWindowWillCloseNotification
+                    object:chrome_window->GetNativeWindow()];
+  CheckHasAppMenus(app_1_);
+
+  app_1_app_window->GetBaseWindow()->Close();
+  CheckNoAppMenus();
+}
+
 // Test to check that hosted apps have "Find" and "Paste and Match Style" menu
 // items under the "Edit" menu.
 IN_PROC_BROWSER_TEST_F(AppShimMenuControllerBrowserTest,
                        HostedAppHasAdditionalEditMenuItems) {
   SetUpApps(HOSTED | PACKAGED_1);
 
   // Find the first hosted app window.
   Browser* hosted_app_browser = nullptr;
   BrowserList* browsers =
       BrowserList::GetInstance(chrome::HOST_DESKTOP_TYPE_NATIVE);
@@ skipping 24 matching lines @@
 IN_PROC_BROWSER_TEST_F(AppShimMenuControllerBrowserTest,
                        ExtensionUninstallUpdatesMenuBar) {
   SetUpApps(PACKAGED_1 | PACKAGED_2);
 
   // This essentially tests that a NSWindowWillCloseNotification gets fired when
   // an app is uninstalled. We need to close the other windows first since the
   // menu only changes on a NSWindowWillCloseNotification if there are no other
   // windows.
   FirstWindowForApp(app_2_)->GetBaseWindow()->Close();
   chrome::BrowserIterator()->window()->Close();
+  NSWindow* app_1_window = FirstWindowForApp(app_1_)->GetNativeWindow();
   [[NSNotificationCenter defaultCenter]
       postNotificationName:NSWindowDidBecomeMainNotification
-                    object:FirstWindowForApp(app_1_)->GetNativeWindow()];
+                    object:app_1_window];
+  ScopedFakeWindowMainStatus app_1_is_main(app_1_window);
 
   CheckHasAppMenus(app_1_);
   ExtensionService::UninstallExtensionHelper(
       extension_service(),
       app_1_->id(),
       extensions::UNINSTALL_REASON_FOR_TESTING);
   CheckNoAppMenus();
 }
 
 }  // namespace
+
+@implementation IsMainWindowDonorForWindow
+- (BOOL)isMainWindow {
+  NSWindow* selfAsWindow = base::mac::ObjCCastStrict<NSWindow>(self);
+  return selfAsWindow == ScopedFakeWindowMainStatus::GetMainWindow();
+}
+@end