Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Side by Side Diff: chrome/browser/ui/views/task_manager_view.cc

Issue 11148007: views: Fix a bunch of dchecks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fixes Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/task_manager/task_manager.h" 5 #include "chrome/browser/task_manager/task_manager.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/metrics/stats_table.h" 9 #include "base/metrics/stats_table.h"
10 #include "base/utf_string_conversions.h" 10 #include "base/utf_string_conversions.h"
(...skipping 697 matching lines...) Expand 10 before | Expand all | Expand 10 after
708 void TaskManagerView::OnDoubleClick() { 708 void TaskManagerView::OnDoubleClick() {
709 ActivateFocusedTab(); 709 ActivateFocusedTab();
710 } 710 }
711 711
712 void TaskManagerView::OnKeyDown(ui::KeyboardCode keycode) { 712 void TaskManagerView::OnKeyDown(ui::KeyboardCode keycode) {
713 if (keycode == ui::VKEY_RETURN) 713 if (keycode == ui::VKEY_RETURN)
714 ActivateFocusedTab(); 714 ActivateFocusedTab();
715 } 715 }
716 716
717 void TaskManagerView::LinkClicked(views::Link* source, int event_flags) { 717 void TaskManagerView::LinkClicked(views::Link* source, int event_flags) {
718 DCHECK(source == about_memory_link_); 718 DCHECK_EQ(about_memory_link_, source);
719 task_manager_->OpenAboutMemory(); 719 task_manager_->OpenAboutMemory();
720 } 720 }
721 721
722 void TaskManagerView::ShowContextMenuForView(views::View* source, 722 void TaskManagerView::ShowContextMenuForView(views::View* source,
723 const gfx::Point& point) { 723 const gfx::Point& point) {
724 UpdateStatsCounters(); 724 UpdateStatsCounters();
725 scoped_ptr<views::Menu> menu(views::Menu::Create( 725 scoped_ptr<views::Menu> menu(views::Menu::Create(
726 this, views::Menu::TOPLEFT, source->GetWidget()->GetNativeView())); 726 this, views::Menu::TOPLEFT, source->GetWidget()->GetNativeView()));
727 for (std::vector<ui::TableColumn>::iterator i(columns_.begin()); 727 for (std::vector<ui::TableColumn>::iterator i(columns_.begin());
728 i != columns_.end(); ++i) { 728 i != columns_.end(); ++i) {
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
807 // Declared in browser_dialogs.h so others don't need to depend on our header. 807 // Declared in browser_dialogs.h so others don't need to depend on our header.
808 void ShowTaskManager() { 808 void ShowTaskManager() {
809 TaskManagerView::Show(false); 809 TaskManagerView::Show(false);
810 } 810 }
811 811
812 void ShowBackgroundPages() { 812 void ShowBackgroundPages() {
813 TaskManagerView::Show(true); 813 TaskManagerView::Show(true);
814 } 814 }
815 815
816 } // namespace chrome 816 } // namespace chrome
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698