Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 1114793002: Add a license file for about:credits. (Closed)

Created:
5 years, 7 months ago by tfarina
Modified:
5 years, 7 months ago
Reviewers:
tkent, piman
CC:
blink-reviews, Avi (use Gerrit), boliu, brettw, Daniel Berlin, darin (slow to review), jam, jamesr, jochen (gone - plz use gerrit), pilgrim_google, piman
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add a license file for about:credits. We need to add this license file because we are removing webkit/ in https://codereview.chromium.org/1102673007/, so we need a new home for it, in order to keep licenses.py working. BUG=338338 R=tkent@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194678

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+967 lines, -0 lines) Patch
A LICENSE_FOR_ABOUT_CREDITS View 1 chunk +967 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tfarina
PTAL
5 years, 7 months ago (2015-04-29 03:02:13 UTC) #1
piman
drive-by LGTM FWIW
5 years, 7 months ago (2015-04-29 03:46:00 UTC) #3
tkent
lgtm
5 years, 7 months ago (2015-04-29 20:40:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1114793002/1
5 years, 7 months ago (2015-04-29 20:40:33 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 23:33:39 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194678

Powered by Google App Engine
This is Rietveld 408576698