Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1114743002: mac: Rename the method -layout in MCSettingsButtonCell. (Closed)

Created:
5 years, 7 months ago by erikchen
Modified:
5 years, 7 months ago
CC:
chromium-reviews, peter+watch_chromium.org, mlamouri+watch-notifications_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mac: Rename the method -layout in MCSettingsButtonCell. -layout is the name of a method on NSView that performs constraint based layout. The new method's name is -layoutEntryView. BUG=471823 Committed: https://crrev.com/51fdea3a55e5a1ae2f6eb05c081724cd441cfbd6 Cr-Commit-Position: refs/heads/master@{#327525}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M ui/message_center/cocoa/settings_entry_view.mm View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
erikchen
mark: Please review.
5 years, 7 months ago (2015-04-28 23:26:18 UTC) #2
Mark Mentovai
LGTM
5 years, 7 months ago (2015-04-29 00:37:03 UTC) #3
erikchen
avi: Looking for an OWNER review.
5 years, 7 months ago (2015-04-29 01:28:09 UTC) #5
Avi (use Gerrit)
There's no forward declaration? lgtm stampity stamp
5 years, 7 months ago (2015-04-29 02:17:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1114743002/1
5 years, 7 months ago (2015-04-29 16:57:29 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 18:14:52 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 18:15:59 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/51fdea3a55e5a1ae2f6eb05c081724cd441cfbd6
Cr-Commit-Position: refs/heads/master@{#327525}

Powered by Google App Engine
This is Rietveld 408576698