Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(878)

Unified Diff: content/browser/accessibility/accessibility_event_recorder_win.cc

Issue 1114683002: Filter out AX window events to make tests less flaky. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/accessibility/accessibility_event_recorder_win.cc
diff --git a/content/browser/accessibility/accessibility_event_recorder_win.cc b/content/browser/accessibility/accessibility_event_recorder_win.cc
index 6fa8aae374c63abfbb988c4188ff18ee7589a349..4de7ae5e7d50cf85d95e8161705c7f8673c0aac4 100644
--- a/content/browser/accessibility/accessibility_event_recorder_win.cc
+++ b/content/browser/accessibility/accessibility_event_recorder_win.cc
@@ -206,6 +206,13 @@ void AccessibilityEventRecorderWin::OnWinEventHook(
iaccessible->get_accState(childid_self, state.Receive());
int ia_state = V_I4(state.ptr());
+ // Avoid flakiness. Events fired on a WINDOW are out of the control
+ // of a test.
+ if (role.type() == VT_I4 && ROLE_SYSTEM_WINDOW == V_I4(role.ptr())) {
+ VLOG(1) << "Ignoring event " << event << " on ROLE_SYSTEM_WINDOW";
+ return;
+ }
+
// Avoid flakiness. The "offscreen" state depends on whether the browser
// window is frontmost or not, and "hottracked" depends on whether the
// mouse cursor happens to be over the element.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698