Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 1114683002: Filter out AX window events to make tests less flaky. (Closed)

Created:
5 years, 7 months ago by dmazzoni
Modified:
5 years, 7 months ago
Reviewers:
David Tseng
CC:
chromium-reviews, je_julie(Not used), plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Filter out AX window events to make tests less flaky. The DumpAccessibilityEvent* tests sometimes fail when there's an event on a ROLE_SYSTEM_WINDOW, but these events are out of our control for a non-interactive test, so just filter them out. BUG=none Committed: https://crrev.com/3d79357fea5857f6acad36653a6a3f7282134067 Cr-Commit-Position: refs/heads/master@{#327415}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M content/browser/accessibility/accessibility_event_recorder_win.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dmazzoni
5 years, 7 months ago (2015-04-28 21:15:53 UTC) #2
David Tseng
lgtm
5 years, 7 months ago (2015-04-28 21:21:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1114683002/1
5 years, 7 months ago (2015-04-28 23:12:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 02:00:33 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 02:01:27 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3d79357fea5857f6acad36653a6a3f7282134067
Cr-Commit-Position: refs/heads/master@{#327415}

Powered by Google App Engine
This is Rietveld 408576698