Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1114633003: gpu: Remove testonly header files from service_sources target. (Closed)

Created:
5 years, 7 months ago by tfarina
Modified:
5 years, 7 months ago
Reviewers:
no sievers
CC:
chromium-reviews, piman+watch_chromium.org, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: Remove testonly header files from service_sources target. These headers are intended to be consumed by tests only, not by production code and thus should not be listed in service_sources target. This makes the following errors disappear: ERROR at //gpu/command_buffer/service/gpu_scheduler_mock.h:9:11: Include not allowed. ^---------------------------------- It is not in any dependency of //gpu/command_buffer/service:service_sources The include file is in the target(s): //testing/gmock:gmock which should somehow be reachable. ERROR at //gpu/command_buffer/service/mocks.h:22:11: Include not allowed. ^---------------------------------- It is not in any dependency of //gpu/command_buffer/service:service_sources The include file is in the target(s): //testing/gmock:gmock which should somehow be reachable. Tested on Linux with the following command lines: $ gn gen out-gn/Debug $ gn check out-gn/Debug //gpu/command_buffer/service/* BUG=367595, 376000 TEST=see above R=sievers@chromium.org Committed: https://crrev.com/d1d9e928cabf90e24d17fc2b12b67bfe4b9d7431 Cr-Commit-Position: refs/heads/master@{#327384}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M gpu/command_buffer/service/BUILD.gn View 2 chunks +0 lines, -2 lines 1 comment Download

Messages

Total messages: 6 (1 generated)
tfarina
PTAL! https://codereview.chromium.org/1114633003/diff/1/gpu/command_buffer/service/BUILD.gn File gpu/command_buffer/service/BUILD.gn (left): https://codereview.chromium.org/1114633003/diff/1/gpu/command_buffer/service/BUILD.gn#oldcode79 gpu/command_buffer/service/BUILD.gn:79: "gpu_scheduler_mock.h", I will remove this in a follow ...
5 years, 7 months ago (2015-04-28 19:15:56 UTC) #1
no sievers
lgtm
5 years, 7 months ago (2015-04-28 20:05:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1114633003/1
5 years, 7 months ago (2015-04-28 21:36:45 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-28 23:09:38 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 23:10:30 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d1d9e928cabf90e24d17fc2b12b67bfe4b9d7431
Cr-Commit-Position: refs/heads/master@{#327384}

Powered by Google App Engine
This is Rietveld 408576698